Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump hdwallet to latest #5538

Merged
merged 3 commits into from
Oct 25, 2023
Merged

feat: bump hdwallet to latest #5538

merged 3 commits into from
Oct 25, 2023

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Oct 25, 2023

Description

Includes shapeshift/hdwallet#650 and shapeshift/hdwallet#651

Pull Request Type

  • ๐Ÿ› Bug fix (Non-breaking Change: Fixes an issue)
  • ๐Ÿ› ๏ธ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • ๐Ÿ’… New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A

Risk

Zero to none, imports changed for ethers is the only actual runtime change here, though a paranoia smoke check of Ethereum message signing (i.e CoW signing or wherever verification) won't hurt here

Testing

  • None with the Ledger flag off, though see risks for paranoia checks
  • With the Ledger flag on, address verification is working for BCH, and the address on the device is matching the one in the verify screen (minus bitcoincash:)

Engineering

  • โ˜๐Ÿฝ

Operations

  • โ˜๐Ÿฝ

Screenshots (if applicable)

image image

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@gomesalexandre gomesalexandre marked this pull request as ready for review October 25, 2023 21:40
@gomesalexandre gomesalexandre requested a review from a team as a code owner October 25, 2023 21:40
@0xdef1cafe 0xdef1cafe enabled auto-merge (squash) October 25, 2023 22:11
@0xdef1cafe 0xdef1cafe merged commit 655152a into develop Oct 25, 2023
3 checks passed
@0xdef1cafe 0xdef1cafe deleted the feat_bump_hdwallet branch October 25, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants